Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Eigen cmake header references #1544

Merged
merged 2 commits into from Dec 22, 2023

Conversation

ghutchis
Copy link
Member

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member Author

@drew-parsons - seems to be failing on the Windows build for Python wheels, which is annoying. It's looking for -DEigen3_INCLUDE_DIR:PATH=C:/eigen but I can't figure out where that happens.

@drew-parsons
Copy link
Contributor

drew-parsons commented Dec 21, 2023

What is the location of the Windows installation exactly?

Does the suggestion at https://stackoverflow.com/a/67303140/12401525 help, setting EIGEN3_INCLUDE_DIR (or Eigen3_DIR) when calling cmake in the windows script? Is %EIGEN3_ROOT% defined for windows?

[**edit Eigen docs suggest setting Eigen3_DIR if it's installed in a non-default path]

@drew-parsons
Copy link
Contributor

There's also https://stackoverflow.com/a/55476486/12401525
which suggests the Windows location might be C:\Program Files(X86)\Eigen3

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
@ghutchis ghutchis merged commit 3a2fbd2 into OpenChemistry:master Dec 22, 2023
18 checks passed
@ghutchis ghutchis deleted the fix-eigen3 branch December 22, 2023 00:47
@ghutchis ghutchis changed the title Apply patch from Drew Parsons @debichem Update Eigen cmake header references Dec 22, 2023
@avo-bot
Copy link

avo-bot commented Dec 22, 2023

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/december-2023-live-updates/5051/1

Copy link
Contributor

Here are the build results
Avogadro2.AppImage
Artifacts will only be retained for 90 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core contains inconsistent cmake header reference to Eigen3::Eigen3
3 participants