Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt build from avogadroapp to include OpenSSL dll for Windows #1604

Merged
merged 4 commits into from Feb 10, 2024

Conversation

ghutchis
Copy link
Member

@ghutchis ghutchis commented Feb 8, 2024

Should fix HTTPS connections on Windows

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Should fix HTTPS connections on Windows

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

Copy link
Contributor

github-actions bot commented Feb 9, 2024

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Win64.exe
Artifacts will only be retained for 90 days.

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis ghutchis added the build label Feb 10, 2024
@ghutchis ghutchis merged commit ec07059 into OpenChemistry:master Feb 10, 2024
22 checks passed
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@avo-bot
Copy link

avo-bot commented Feb 17, 2024

This pull request has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/february-2024-live-updates/5250/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants