Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erratic editing behavior #819

Merged
merged 1 commit into from Jan 22, 2022
Merged

Conversation

aerkiaga
Copy link
Collaborator

This fixes the regression described at https://github.com/OpenChemistry/avogadroapp/issues/239. This issue appeared with d2dcfae, due to a small change in avogadro/qtgui/rwmolecule_undo.h wherein RWMolecule::addAtom() was made to be passed m_atomId rather than m_atomUid, when it should expect a UID.

The consequence was that, when two carbons were bonded and their hydrogens adjusted, the hydrogens on one of the carbons would be removed and not be added back, due to the passed UIDs actually being their IDs, which happened to be equal to the removed hydrogens' UIDs.

Then, trying to add atoms around this molecule with 5 atoms would pass atom ID 5 as UID, this being the UID of one of the existing hydrogens, which would simply get moved to the clicked location.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Aritz Erkiaga <aerkiaga3@gmail.com>
@github-actions
Copy link
Contributor

Here are the build results
Avogadro2.AppImage
macOS.dmg
Win64.exe
Artifacts will only be retained for 90 days.

@ghutchis
Copy link
Member

This definitely seems to fix some bugs, so I'm going to merge - and I'll sort out the Ubuntu 20.04 build issue.

@ghutchis ghutchis merged commit 2fbc1b6 into OpenChemistry:master Jan 22, 2022
@welcome
Copy link

welcome bot commented Jan 22, 2022

Congrats on merging your first pull request! 🎉 Thanks for making Avogadro better for everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bonding atoms manually doesn't work (regression?)
2 participants