Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Done' Button Implementation #2177

Merged
merged 20 commits into from
Sep 1, 2021
Merged

'Done' Button Implementation #2177

merged 20 commits into from
Sep 1, 2021

Commits on Sep 1, 2021

  1. Implemented a 'DoneableOperator' with a 'Done' button, allowing itera… 

    …tive operators to be prematurely finished but still have their data used in a pipeline.

Signed-off-by: jepi <jacobpietryga@gmail.com>
Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f7d078a View commit details
    Browse the repository at this point in the history

  2. Fixed formatting issues associated with clang-format and flake8 

    Signed-off-by: jepi <jacobpietryga@gmail.com>
Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    470885f View commit details
    Browse the repository at this point in the history

  3. Fixing last clang-format issue 

    Signed-off-by: jepi <jacobpietryga@gmail.com>
Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    01bd6ef View commit details
    Browse the repository at this point in the history

  4. Fixing last clang-format issue 

    Signed-off-by: jepi <jacobpietryga@gmail.com>
Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    91a82e7 View commit details
    Browse the repository at this point in the history

  5. Fixing last clang-format issue 

    Signed-off-by: jepi <jacobpietryga@gmail.com>
Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1a2dffa View commit details
    Browse the repository at this point in the history

  6. Chris' recommended updates for naming 

    Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    ddd916a View commit details
    Browse the repository at this point in the history

  7. Fixed to be "EarlyCancelable" Operator 

    Signed-off-by: Jacob Pietryga <jepi@umich.edu>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    a1999ae View commit details
    Browse the repository at this point in the history

  8. Fixed flake and clang issues, no thirdparty change, updated more oepr… 

    …ators to be early cancelable

Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    81df160 View commit details
    Browse the repository at this point in the history

  9. Further adjustment of flake8 and clang issues 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8796f9c View commit details
    Browse the repository at this point in the history

  10. Fix of line length flake issue 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    eb8b627 View commit details
    Browse the repository at this point in the history

  11. flake8 fix 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    b8c9143 View commit details
    Browse the repository at this point in the history

  12. Added "# no qa" to account for a few intentional formatting issues 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    68c39b9 View commit details
    Browse the repository at this point in the history

  13. ' # no qa' to '# noqa' 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    5c26443 View commit details
    Browse the repository at this point in the history

  14. ' # noqa' for function header rather than conditionals 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9f77c2f View commit details
    Browse the repository at this point in the history

  15. Fixed whitespace trailing on previous comment lines 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    14ae028 View commit details
    Browse the repository at this point in the history

  16. Updating nomenclature: "EarlyComplete" -> "Complete" 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    f6ddd84 View commit details
    Browse the repository at this point in the history

  17. Fixing 'clang' issues 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    1eb1b67 View commit details
    Browse the repository at this point in the history

  18. Shortening Conditional 

    Co-authored-by: Christian Clauss <cclauss@me.com>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga @cclauss
    jepietryga and cclauss committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    3d45c18 View commit details
    Browse the repository at this point in the history

  19. Apply suggestions from code review 

    Co-authored-by: Christian Clauss <cclauss@me.com>
Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga @cclauss
    jepietryga and cclauss committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    9d487e2 View commit details
    Browse the repository at this point in the history

  20. Set noqa to be C901 only 

    Signed-off-by: jepietryga <jacobpietryga@gmail.com>
    @jepietryga
    jepietryga committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    844e5f1 View commit details
    Browse the repository at this point in the history