Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a crash when .gaml files contain peak data but no baseline #228

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fixed a crash when .gaml files contain peak data but no baseline #228

merged 1 commit into from
Mar 21, 2022

Conversation

Mailaender
Copy link
Member

Every <peak> element must contain one <peakXvalue> and one <peakYvalue> element. In addition, there can be an optional <baseline> element. http://gaml.org/Documentation/XML%20Analytical%20Archive%20Format.pdf

Closes #227

@eselmeister eselmeister merged commit 8cfd1f0 into OpenChrom:develop Mar 21, 2022
@Mailaender Mailaender deleted the gaml-null-baseline branch March 21, 2022 09:12
@Mailaender Mailaender mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException when loading GAML with peak data
2 participants
@Mailaender @eselmeister