Case sensitive keywords auto-completion

[Astalaseven]

This issue is related to issue #1.

OCI proposes to auto-complete lower variable name with upper names, for example end- suggests END-PERFORM but not end-perform.

A quick fix could be to add the lower names into the keywords in pyQode:

ALL_KEYWORDS = PSEUDO + RESERVED + NAME_CONSTANTS + FUNCTIONS
ALL_KEYWORDS += [keyword.lower() for keyword in ALL_KEYWORDS]

https://github.com/pyQode/pyqode.cobol/blob/master/pyqode/cobol/api/keywords.py#L105

[ColinDuquesnoy]

Not sure it is related to #1. At that time the problem was that there was a mode that was converting any key pressed to upper case, meaning it was impossible to type in lower case. This was not related to auto completion.

At that time we agreed that:

a good practice is to use upper case for COBOL reserved words, and lower case for anything else.

That's why auto completion propose reserved keyworkds as UPPER CASE.

[ColinDuquesnoy]

Instead of having both versions (upper case and lower case) as you suggest. I would prefer to have an option that let you choose your preferred convention.

[Astalaseven]

In fact, what really is used is dependent on different workshops policies. The point here, it is not up to the editor to enforce anything but leave that decision to end users.

Yes, it's a convention and it should be better to let the user choose it (I don't know a lot of languages where we have to put the keywords uppercase, and I find that disturbing in my code, and problematic when you are on a mainframe/as400 where you cannot use CapsLock because it affects some commands)

[ColinDuquesnoy]

Right. Then let's add that option.

All I have to do is to check the setting and transform any keyword to lower case here: https://github.com/pyQode/pyqode.cobol/blob/master/pyqode/cobol/backend/workers.py#L45.

[ColinDuquesnoy]

I added the option:

Let me know if that works for you (this time, you will need to uprade all pyqode packages as well)

[Astalaseven]

Yep it works, thanks!

[Astalaseven]

Should it be possible to do it globally (not only the keywords)? For example, the variables:

[ColinDuquesnoy]

Good catch!

I think this is a bug I introduced in a recent commit where I improved the names parser (it used to respect the original case). I don't have a test for lower case variables at the moment so this bug was undetected.

[ColinDuquesnoy]

Should be fixed now (and I added a test). You need to upgrade pyqode.cobol from source checkout.

[Astalaseven]

Le 22/12/2014 13:32, Colin Duquesnoy a écrit :

Should be fixed now (and I added a test). You need to upgrade
pyqode.cobol from source checkout.

—
Reply to this email directly or view it on GitHub
#87 (comment).

Yep it works thank you!