fix(enrolling): change email address as required field

Also improve some logging and update nuget package dependency
OpenCodeFoundation · Jun 27, 2020 · e3da303 · e3da303
1 parent 0ac94ec
commit e3da303
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.../Enrolling/Enrolling.API/Application/Validations/EnrollmentApplicationCommandValidator.cs b/.../Enrolling/Enrolling.API/Application/Validations/EnrollmentApplicationCommandValidator.cs
@@ -9,7 +9,7 @@ public class EnrollmentApplicationCommandValidator
         public EnrollmentApplicationCommandValidator()
         {
             RuleFor(application => application.Name).NotEmpty();
-            RuleFor(application => application.Email).EmailAddress();
+            RuleFor(application => application.Email).NotEmpty().EmailAddress();
             RuleFor(application => application.Mobile).NotEmpty();
         }
     }

diff --git a/src/Services/Enrolling/Enrolling.API/Enrolling.API.csproj b/src/Services/Enrolling/Enrolling.API/Enrolling.API.csproj
@@ -32,7 +32,7 @@
     <PackageReference Include="Serilog.Sinks.Seq" Version="4.0.0" />
 
     <!-- Swagger -->
-    <PackageReference Include="Swashbuckle.AspNetCore" Version="5.5.0" />
+    <PackageReference Include="Swashbuckle.AspNetCore" Version="5.5.1" />
 
     <!-- Need this package for generating migration files -->
     <PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="3.1.5">

diff --git a/src/Services/Enrolling/Enrolling.API/IWebHostExtensions.cs b/src/Services/Enrolling/Enrolling.API/IWebHostExtensions.cs
@@ -21,7 +21,7 @@ public static IHost MigrateDbContext<TContext>(this IHost webHost, Action<TConte
 
                 try
                 {
-                    logger.LogInformation($"Migrating database associated with context { typeof(TContext).Name}");
+                    logger.LogInformation("Migrating database associated with context {ContextName}", typeof(TContext).Name);
 
                     var retry = Policy.Handle<SqlException>()
                         .WaitAndRetry(new TimeSpan[]

diff --git a/src/Services/Enrolling/Enrolling.API/Startup.cs b/src/Services/Enrolling/Enrolling.API/Startup.cs
@@ -46,6 +46,10 @@ public void ConfigureServices(IServiceCollection services)
                 });
 
             services.AddControllers()
+                .AddJsonOptions(options =>
+                {
+                    options.JsonSerializerOptions.IgnoreNullValues = true;
+                })
                 .AddFluentValidation(fv =>
                     fv.RegisterValidatorsFromAssemblyContaining<EnrollmentApplicationCommandValidator>());