Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Library Management Service initial implementation #427

Merged
merged 6 commits into from Jul 24, 2021
Merged

Library Management Service initial implementation #427

merged 6 commits into from Jul 24, 2021

Conversation

sohan093007
Copy link
Contributor

@sohan093007 sohan093007 commented Jun 8, 2021 •
edited by ratanparai

closes #350

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

sohan093007
sohan093007 commented Jun 8, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library Management Service initial implementation

NitaiBanik
NitaiBanik reviewed Jun 11, 2021
View reviewed changes
src/Services/LibraryManagement/LibraryManagement.API/Startup.cs Outdated
app.UseDeveloperExceptionPage();
}
app.UseSwagger();
app.UseSwaggerUI(c => c.SwaggerEndpoint("/swagger/v1/swagger.json", "LibraryManagement.API v1"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the indentation here?

src/Services/LibraryManagement/LibraryManagement.API/Controllers/HelloWorldController.cs Show resolved Hide resolved
sohan093007
sohan093007 commented Jun 12, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes according to Nitai's Comment.

sohan093007
sohan093007 commented Jun 12, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LibraryMangment after indentation

sohan093007
sohan093007 commented Jun 12, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LibraryMangment after indentation

ratanparai
ratanparai suggested changes Jul 3, 2021
View reviewed changes
src/Services/LibraryManagement/LibraryManagement.API/Startup.cs Outdated
app.UseSwagger();
app.UseSwaggerUI(c => c.SwaggerEndpoint("/swagger/v1/swagger.json", "LibraryManagement.API v1"));

app.UseHttpsRedirection();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove https redirection.

sohan093007
sohan093007 commented Jul 3, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing HTTPS redirection

sohan093007
sohan093007 commented Jul 3, 2021
View reviewed changes
Copy link
Contributor Author

@sohan093007 sohan093007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing https redirection

@ratanparai ratanparai merged commit bce5676 into OpenCodeFoundation:master Jul 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NitaiBanik NitaiBanik NitaiBanik left review comments

@ratanparai ratanparai ratanparai approved these changes

@mahedee mahedee Awaiting requested review from mahedee

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I want to work on Library Management Service
4 participants
@sohan093007 @CLAassistant @ratanparai @NitaiBanik