This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Library Management Service initial implementation#427
Merged
ratanparai merged 6 commits intoOpenCodeFoundation:masterfrom Jul 24, 2021
Merged
Conversation
|
|
sohan093007
commented
Jun 8, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
Library Management Service initial implementation
NitaiBanik
reviewed
Jun 11, 2021
| app.UseDeveloperExceptionPage(); | ||
| } | ||
| app.UseSwagger(); | ||
| app.UseSwaggerUI(c => c.SwaggerEndpoint("/swagger/v1/swagger.json", "LibraryManagement.API v1")); |
Contributor
There was a problem hiding this comment.
Can you please fix the indentation here?
sohan093007
commented
Jun 12, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
Made some changes according to Nitai's Comment.
sohan093007
commented
Jun 12, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
LibraryMangment after indentation
sohan093007
commented
Jun 12, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
LibraryMangment after indentation
ratanparai
suggested changes
Jul 3, 2021
| app.UseSwagger(); | ||
| app.UseSwaggerUI(c => c.SwaggerEndpoint("/swagger/v1/swagger.json", "LibraryManagement.API v1")); | ||
|
|
||
| app.UseHttpsRedirection(); |
sohan093007
commented
Jul 3, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
After removing HTTPS redirection
sohan093007
commented
Jul 3, 2021
Contributor
Author
sohan093007
left a comment
sohan093007
left a comment
There was a problem hiding this comment.
After removing https redirection
ratanparai
approved these changes
Jul 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #350