Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikki lacrima patch oc spy #1004

Conversation

NikkiLacrima
Copy link

Fixing the issues #1003 oc_spy does not clear spy reports after runaway or last owner removed.

@NikkiLacrima NikkiLacrima changed the base branch from master to 8.3_Features-branch November 5, 2023 10:36
@SilkieSabra
Copy link
Contributor

Needs approving review !

@Trinkitz
Copy link

Trinkitz commented Nov 5, 2023

Tested this patch as both an Owner/wearer with two additional owners and as a non-Owner/wearer with three owners. Spy settings cleared following Runaway, and there was no further tracking of the wearer. Seems a successful fix. Thanks!

Copy link
Collaborator

@Medea-Destiny Medea-Destiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me. Sensible quick fix, for 9,x with the move towards linkset data we'll want to handle runaway centrally anyhow so this looks solid for now.

@NikkiLacrima NikkiLacrima merged commit 99905f0 into OpenCollarTeam:8.3_Features-branch Nov 8, 2023
1 check passed
@NikkiLacrima NikkiLacrima deleted the NikkiLacrima-patch-oc_spy branch November 8, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants