PR feedback: Extract encoding into a variable

OpenCombine · Jul 21, 2020 · 81bf68f · 81bf68f
1 parent cfedce2
commit 81bf68f
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/Sources/OpenCombineFoundation/Timer+Publisher.swift b/Sources/OpenCombineFoundation/Timer+Publisher.swift
@@ -338,18 +338,16 @@ extension RunLoop.Mode {
 #else
         return rawValue.withCString {
 #if swift(>=5.3)
-            return CFStringCreateWithCString(
-                nil,
-                $0,
-                CFStringBuiltInEncodings.UTF8.rawValue
-            )
+          let encoding = CFStringBuiltInEncodings.UTF8.rawValue
 #else
-            return CFStringCreateWithCString(
-                nil,
-                $0,
-                CFStringEncoding(kCFStringEncodingUTF8)
-            )
-#endif
+          let encoding = CFStringEncoding(kCFStringEncodingUTF8)
+#endif // swift(>=5.3)
+
+          return CFStringCreateWithCString(
+              nil,
+              $0,
+              encoding
+          )
         }
 #endif
     }