Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a build error on linux: kCFStringEncodingUTF8 is not defined. #173

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Fix a build error on linux: kCFStringEncodingUTF8 is not defined. #173

merged 3 commits into from
Jul 21, 2020

Commits on Jul 17, 2020

  1. Fix a build error on linux: 

    `kCFStringEncodingUTF8` is not defined.
Instead, use `CFStringBuiltInEncodings.UTF8.rawValue`.

Also fix a type error I was getting in a unit test.
    @adamseesaw
    adamseesaw committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    20abe1e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. Conditionalize the change to use CFStringBuiltInEncodings only in s… 

    …wift 5.3 and later, as it does not compile on swift 5.2 on linux (but does on swift 5.2 for mac, suggesting a fixed bug in the open source version of CoreFoundation?)
    @adamseesaw
    adamseesaw committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    cfedce2 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. PR feedback: Extract encoding into a variable

    @adamseesaw
    adamseesaw committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    81bf68f View commit details
    Browse the repository at this point in the history