Fixed Timer(timeInterval:,repeats:,block:) not accounting timeInterval for the first fire date. #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/OpenCombine/OpenCombine/blob/master/Sources/OpenCombineFoundation/Helpers/Portability.swift#L58-L64
It looks like this was a typo/something overlooked, but basically, this
fire: Date()
breaks at least every timer publisher likeTimer.publish(every: timeInterval, on: .main, in: .default)
, as it basically results in the first event fired immediately vs in timeInterval. (Just in case, no, Combine does not fire that extra event).