Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GYB tool to implement MapKeyPath #71

Merged
merged 7 commits into from Oct 8, 2019
Merged

Use GYB tool to implement MapKeyPath #71

merged 7 commits into from Oct 8, 2019

Conversation

broadwaylamb
Copy link
Member

@broadwaylamb broadwaylamb commented Oct 3, 2019 •
edited

No description provided.

@broadwaylamb broadwaylamb added the missing functionality This functionality is present in Apple's Combine but we don't have it yet label Oct 3, 2019
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Oct 3, 2019
@broadwaylamb broadwaylamb mentioned this pull request Oct 3, 2019
Open
83 tasks
@OpenCombineBot
Copy link

OpenCombineBot commented Oct 3, 2019 •
edited

LGTM

Generated by 🚫 Danger Swift against eaf9ed2

@codecov
Copy link

codecov bot commented Oct 3, 2019 •
edited

Codecov Report

Merging #71 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   96.59%   96.72%   +0.13%     
==========================================
  Files          50       51       +1     
  Lines        2230     2320      +90     
==========================================
+ Hits         2154     2244      +90     
  Misses         76       76
Impacted Files Coverage Δ
...e/Publishers/GENERATED-Publishers.MapKeyPath.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b9e87...eaf9ed2. Read the comment docs.

@broadwaylamb broadwaylamb mentioned this pull request Oct 4, 2019
Draft
6 tasks
@broadwaylamb broadwaylamb force-pushed the mapKeyPath branch 3 times, most recently from 2b6f053 to 80e32c2 Compare October 8, 2019 19:02
@broadwaylamb broadwaylamb merged commit 9eabadb into master Oct 8, 2019
OpenCombine automation moved this from In progress to Done Oct 8, 2019
@broadwaylamb broadwaylamb deleted the mapKeyPath branch October 8, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
missing functionality This functionality is present in Apple's Combine but we don't have it yet
Projects
OpenCombine
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@broadwaylamb @OpenCombineBot