Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all reduce-like operators #76

Merged
merged 12 commits into from Oct 15, 2019
Merged

Implement all reduce-like operators #76

merged 12 commits into from Oct 15, 2019

Conversation

broadwaylamb
Copy link
Member

@broadwaylamb broadwaylamb commented Oct 9, 2019 •
edited

Implementing

  • Reduce
  • TryReduce
  • Collect
  • Count
  • Comparison
  • Contains
  • ContainsWhere
  • TryContainsWhere
  • AllSatisfy
  • TryAllSatisfy
  • First
  • FirstWhere
  • TryFirstWhere
  • Last
  • LastWhere
  • TryLastWhere

Testing

  • Add generic tests
  • Add publisher-specific tests

@broadwaylamb broadwaylamb added the missing functionality This functionality is present in Apple's Combine but we don't have it yet label Oct 9, 2019
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Oct 9, 2019
This was referenced Oct 9, 2019
Closed
Closed
Closed
Open
@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited

Codecov Report

Merging #76 into master will increase coverage by 0.18%.
The diff coverage is 95.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   96.52%   96.71%   +0.18%     
==========================================
  Files          51       58       +7     
  Lines        2332     2646     +314     
==========================================
+ Hits         2251     2559     +308     
- Misses         81       87       +6
Impacted Files Coverage Δ
Sources/OpenCombine/Helpers/Violations.swift 15.38% <0%> (ø) ⬆️
...rces/OpenCombine/Publishers/Publishers.Count.swift 100% <100%> (ø) ⬆️
...ources/OpenCombine/Helpers/PartialCompletion.swift 100% <100%> (ø)
...s/OpenCombine/Publishers/Publishers.Contains.swift 100% <100%> (ø)
...OpenCombine/Publishers/Publishers.AllSatisfy.swift 100% <100%> (ø)
...es/OpenCombine/Publishers/Publishers.Collect.swift 100% <100%> (ø)
...urces/OpenCombine/Publishers/Publishers.Last.swift 100% <100%> (ø)
...ces/OpenCombine/Publishers/Publishers.Reduce.swift 100% <100%> (ø)
...OpenCombine/Publishers/Publishers.Comparison.swift 100% <100%> (ø)
...rces/OpenCombine/Publishers/Publishers.First.swift 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693d114...52316d8. Read the comment docs.

@broadwaylamb broadwaylamb force-pushed the trivial-publishers-fixes branch 2 times, most recently from 22545f0 to 781d9c1 Compare October 9, 2019 16:19
@broadwaylamb broadwaylamb marked this pull request as ready for review October 9, 2019 16:19
@broadwaylamb broadwaylamb force-pushed the trivial-publishers-fixes branch 8 times, most recently from 92def75 to c490c55 Compare October 15, 2019 12:04
@OpenCombineBot
Copy link

OpenCombineBot commented Oct 15, 2019 •
edited

LGTM

Generated by 🚫 Danger Swift against 52316d8

@broadwaylamb broadwaylamb merged commit a08b99c into master Oct 15, 2019
OpenCombine automation moved this from In progress to Done Oct 15, 2019
@broadwaylamb broadwaylamb deleted the trivial-publishers-fixes branch October 15, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
missing functionality This functionality is present in Apple's Combine but we don't have it yet
Projects
OpenCombine
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@broadwaylamb @OpenCombineBot @spadafiva