Print the key-id in the SSO locations of the IdP metadata #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rollover key was not present in the IdP metadat of EngineBlock. This is taken care of in this commit. An additional challenge arose: The Key Id is not always explicitly defined when opening the IdP metadata, in fact it is only used in roll-over scenarios. Setting the default by default caused the SSO URl to be filled with key:default. Where this is not a requirement. https://www.pivotaltracker.com/story/show/174672018
MKodde
changed the title
MKodde
commented
Sep 7, 2020
Comment on lines
+46
to
+48
| if ($identifier === null) { | ||
| $identifier = self::DEFAULT_KEY_PAIR_IDENTIFIER; | ||
| } |
There was a problem hiding this comment.
Instead of doing this in the controller, what was previously the case. We now set the default identifier in the KeyPairFactory. This prevents other users of the Key from using the default key-id
thijskh
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rollover key was not present in the IdP metadata of EngineBlock. This is taken care of in this commit.
An additional challenge arose: The Key Id is not always explicitly defined when opening the IdP metadata, in fact it is only used in roll-over scenarios. Setting the default by default caused the SSO URl to be filled with key:default. Where this is not a requirement.
https://www.pivotaltracker.com/story/show/174672018