Stop using SURFconextId as user identifier #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nameId value is now used instead. Containing the exact same value as long as the NameID was configured to be unspecified (which it is in our case). The NameID can already be read from the AuthenticatedUser object, so manually retrieving it from the assertion subject is not required. The ConsentService could be cleaned up drastically. https://www.pivotaltracker.com/story/show/164103691
|
The build breaks on the security checker. These issues are addressed in #113 |
pablothedude
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nameId value is now used instead. Containing the exact same value
as long as the NameID was configured to be unspecified (which it is in
our case).
The NameID can already be read from the AuthenticatedUser object, so
manually retrieving it from the assertion subject is not required.
The ConsentService could be cleaned up drastically.
https://www.pivotaltracker.com/story/show/164103691