Support the amended institution parameter #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VerifiedSecondFactorSearchQuery now takes the institution as one of its arguments. This argument is mandatory and is now added to all the calls of the VerifiedSecondFactorSearch service call. See https://www.pivotaltracker.com/story/show/160283514
- We need a custom composer.json and lock file in order to not be dependend on the file/symlink installation of the mw client bundle - Enable travis builds on the fga feature branches
pablothedude
approved these changes
Oct 18, 2018
| * @return VerifiedSecondFactorCollection | ||
| */ | ||
| public function findVerifiedByIdentity($identityId) | ||
| public function findVerifiedByIdentity($identityId, $insitution) |
The getRegistrationCode method was not used.
For the VerifiedSecondFactorSearchQuery, fixing a typo in the process.
MKodde
force-pushed
the
feature/fga-verified-sf-institution
branch
from
36a82db
to
cf7f79f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VerifiedSecondFactorSearchQuery now takes the institution as
one of its arguments. This argument is mandatory and is now added
to all the calls of the VerifiedSecondFactorSearch service call.
See https://www.pivotaltracker.com/story/show/160283514