Move remote vetting parameters to dist file #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/remote-vetting-full-e2e-test
branch
from
ce6cb9e
to
006ade4
Compare
pablothedude
force-pushed
the
feature/remote-vetting-move-rv-parameters-to-dist
branch
from
5661392
to
0e1e571
Compare
pablothedude
force-pushed
the
feature/remote-vetting-move-rv-parameters-to-dist
branch
from
b45fded
to
a030aee
Compare
MKodde
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Thanks for moving this! Some of the parameters could do with some additional explanation. We can do that at a later stage, but I'm tempted to commit a proposal to this PR if you dont mind. Feel free to pop it of the PR if you think it makes no sense
Also please mention a Pivotal ticket so I can review to those specifications
pablothedude
force-pushed
the
feature/remote-vetting-full-e2e-test
branch
3 times, most recently
from
b26bf18
to
613ea9d
Compare
|
Thanks, will keep your commit, it's a valuable commit. |
pablothedude
force-pushed
the
feature/remote-vetting-move-rv-parameters-to-dist
branch
from
b0f682c
to
ae76a1c
Compare
The remote vetting parameters need to be moved to be independent of install. This was not done during development to keep all parameters the same during development.
pablothedude
force-pushed
the
feature/remote-vetting-move-rv-parameters-to-dist
branch
from
ae76a1c
to
5f37ecb
Compare
pablothedude
deleted the
feature/remote-vetting-move-rv-parameters-to-dist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remote vetting parameters need to be moved to be independent
of install. This was not done during development to keep
all parameters the same during development.
https://www.pivotaltracker.com/story/show/171928781
Please review #201 first