Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Remote Vetting cleanup #220

Merged
merged 8 commits into from
Feb 26, 2021
Merged

Initial Remote Vetting cleanup #220

merged 8 commits into from
Feb 26, 2021

Commits on Feb 24, 2021

  1. Remove double escaping from match logging 

    This is done to ease analysing the identity data.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    468d6f4 View commit details
    Browse the repository at this point in the history

  2. Remove RV SP configuration and make it static 

    Make the acs location static for remote vetting.
This doesn't need to be configurable.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    512eef1 View commit details
    Browse the repository at this point in the history

  3. Fix double escaping of RemoteVettingProcessDto 

    Remove the double escaping of objects in the process DTO so
it would be easier to maintain later on.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    ef7a1a1 View commit details
    Browse the repository at this point in the history

  4. Use mock IdP for testing 

    Use dedicated mock endpoint for testing instead of relying on Irma
configuration. So this won't conflict when using Deploy.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3aae359 View commit details
    Browse the repository at this point in the history

  5. Cleanup configuration and separate dev test and prod config 

    Move the mock services out of the production service configuration.
This is better in terms of defence-in-depth.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    04cd408 View commit details
    Browse the repository at this point in the history

  6. Add assertions in the SessionStorage tests 

    Add assertion to the session test to get rid of risky tests.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    4b0fbd0 View commit details
    Browse the repository at this point in the history

  7. Use a dedicated encryption keypair for tests 

    Use a dedicated encryption key-pair in tests to ease maintenance.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    31ec0aa View commit details
    Browse the repository at this point in the history

  8. Add ApplicationHelper to RemoteVettingService integration test 

    Use the ApplicationHelper itself instead of a mock in the integration
test to test it's behavior.
    @pablothedude
    pablothedude committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    c49e1c1 View commit details
    Browse the repository at this point in the history