Require step up authentication for Recovery Token create and delete actions #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MKodde
commented
Jun 23, 2022
•
MKodde
commented
- In preparation, the SAT controller was cleaned up by segregating the dedicated RT actions from the registration related actions
- The 'test' authentication consume assertion endpoint was re-re-used to also serve self-asserted recovery token step up authentications. I considered creating a new SFO SP for this. But that would get complex really soon. The step up bundle does not support multiple ACS locations either. So this solution seemed to fit best.
MKodde
force-pushed
the
feature/sat-recovery-token-finetuneing
branch
from
6fb761c
to
67bc092
Compare
MKodde
force-pushed
the
feature/sat-require-step-up-for-rt-create-delete
branch
from
1cc3e17
to
0d33d98
Compare
This was previously set to 2, eliminating self-asserted tokens from the token test in GW.
MKodde
force-pushed
the
feature/sat-require-step-up-for-rt-create-delete
branch
from
0d33d98
to
9fc2366
Compare
MKodde
changed the base branch from
feature/sat-recovery-token-finetuneing
to
feature/self-asserted-tokens
MKodde
force-pushed
the
feature/sat-require-step-up-for-rt-create-delete
branch
2 times, most recently
from
52c42a3
to
5285e07
Compare
The SAT registration and dedicated Recovery token actions have been decoupled into separate controllers. The shared logic is placed in a trait. For now the constructors of both controllers are the same, and they now live in the trait. All controller actions have been given a developer friendly description with a high level description of what the action is responsible for.
The RT state storage is used heavily to indicate when step up is given. And to verify when the user still needs to give step-up to perform create and delete actions on the Recovert Tokens.
MKodde
force-pushed
the
feature/sat-require-step-up-for-rt-create-delete
branch
from
5285e07
to
a9925e2
Compare
MKodde
force-pushed
the
feature/sat-require-step-up-for-rt-create-delete
branch
from
8d99ecf
to
5da7f21
Compare
pablothedude
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.