Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support self-vetting using a self-asserted token #284

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Support self-vetting using a self-asserted token #284

merged 2 commits into from
Feb 16, 2023

Conversation

MKodde
Copy link
Member

@MKodde MKodde commented Feb 16, 2023 •
edited
Loading

For details read the story: https://www.pivotaltracker.com/story/show/184292087
For the MW accompanying this change see: OpenConext/Stepup-Middleware#401

MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 16, 2023
@MKodde
Support self-vetting of self-asserted tokens
366e223 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
@MKodde MKodde mentioned this pull request Feb 16, 2023
Merged
@MKodde MKodde force-pushed the feature/allow-self-vetting-with-sat-authoring-token branch 3 times, most recently from 659400a to 8ad6a03 Compare February 16, 2023 14:44
@MKodde MKodde changed the title WIP Support self-vetting using a self-asserted token Feb 16, 2023
@MKodde MKodde force-pushed the feature/allow-self-vetting-with-sat-authoring-token branch from 8ad6a03 to 5d618fe Compare February 16, 2023 14:52
@MKodde MKodde merged commit c9ab903 into develop Feb 16, 2023
MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 16, 2023
@MKodde
Support self-vetting of self-asserted tokens
76cd89a 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 16, 2023
@MKodde
Support self-vetting of self-asserted tokens
d61c633 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 20, 2023
@MKodde
Support self-vetting of self-asserted tokens
0391a14 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
Shaky212
Shaky212 reviewed Feb 20, 2023
View reviewed changes
Copy link

@Shaky212 Shaky212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just found a minor dev left-over!

src/Surfnet/StepupSelfService/SelfServiceBundle/Tests/Service/SelfVetMarshallerTest.php
@@ -52,6 +52,14 @@ class SelfVetMarshallerTest extends TestCase
* @var InstitutionConfigurationOptionsService
*/
private $institutionConfigService;
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some left-over?

MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 20, 2023
@MKodde
Support self-vetting of self-asserted tokens
aa513b9 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

Also:
- Security updates where installed
- Composer and Symfony lockfiles where updated

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 20, 2023
@MKodde
Support self-vetting of self-asserted tokens
ff297fe 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

Also:
- Security updates where installed
- Composer and Symfony lockfiles where updated

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
MKodde added a commit to OpenConext/Stepup-Middleware that referenced this pull request Feb 20, 2023
@MKodde
Support self-vetting of self-asserted tokens
cf72d2c 
When an Identity is in possession of a vetted self-asserted token. It
should be allowed to self-vet successive tokens using that SAT. But only
when all tokens are of the SAT type. Once an Identity is in possession
of an idenity vetted token (vetted on-premise), all following self
vetting tokens must be done with the identity vetted token.

Also:
- Security updates where installed
- Composer and Symfony lockfiles where updated

For details see: https://www.pivotaltracker.com/story/show/184292087
And: OpenConext/Stepup-SelfService#284
@MKodde MKodde deleted the feature/allow-self-vetting-with-sat-authoring-token branch October 18, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaky212 Shaky212 Shaky212 left review comments

@pmeulen pmeulen Awaiting requested review from pmeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MKodde @Shaky212