Require SMS recovery token authentication #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recovering a SF token using your recovery token, the SMS option did not require an SMS authentication. That was fixed in this PR During registration, the SMS auth step is not required as you just registered the SMS recovery token in that case. And that is enough proof of possession at that point. But during recovery of a SF token, you are required to prove possession of your recovery token. For the safe-store RT that would already work. See: https://www.pivotaltracker.com/story/show/185099092
MKodde
force-pushed
the
feature/auth-sms-rt-during-recovery-of-sf-token
branch
from
e529e8d
to
76548f0
Compare
phavekes
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recovering a SF token using your recovery token, the SMS option did not require an SMS authentication. That was fixed in this PR
During registration, the SMS auth step is not required as you just registered the SMS recovery token in that case. And that is enough proof of possession at that point. But during recovery of a SF token, you are required to prove possession of your recovery token.
For the safe-store RT that would already work.
See: https://www.pivotaltracker.com/story/show/185099092