Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary enctype from form #299

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Remove unnecessary enctype from form #299

merged 1 commit into from
Oct 9, 2023

Conversation

tvdijen
Copy link
Contributor

@tvdijen tvdijen commented Oct 5, 2023

OWASP core ruleset will complain about this, because the use of text/plain in conjunction with method=post is effectively useless (form values will never become available in the $_POST global).

The form functions just fine without it.

OWASP core ruleset will complain about this, because the use of `text/plain` in conjunction with `method=post` is effectively useless (form values will never become available in the $_POST global).

The form functions just fine without it.
@tvdijen tvdijen requested a review from MKodde October 5, 2023 21:10
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @tvdijen

Merging. This should land in the next release

@MKodde MKodde merged commit a51a8b6 into develop Oct 9, 2023
1 of 2 checks passed
@MKodde MKodde deleted the tvdijen-patch-1 branch October 9, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants