Ensure display of Authn errors #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SF 6, the new exception handler does not show the exception message in the exception handler. Rather, these errors are handled at another point (authn listeners). Also see: https://stackoverflow.com/questions/40174266/not-all-exceptions-catched-within-the-error-handler
parijke
approved these changes
Mar 6, 2024
|
@thijskh approved |
MKodde
added a commit
that referenced
this pull request
Mar 11, 2024
When rendering the custom exception page, we test if the MissingRequiredAttributeException. But it also had to be a HTTP exception. That was never the case (also before #313). By removing the first part of the statement, the error message is displayed correctly once again.
MKodde
added a commit
that referenced
this pull request
Mar 11, 2024
When rendering the custom exception page, we test if the MissingRequiredAttributeException. But it also had to be a HTTP exception. That was never the case (also before #313). By removing the first part of the statement, the error message is displayed correctly once again.
MKodde
added a commit
that referenced
this pull request
Mar 11, 2024
When rendering the custom exception page, we test if the MissingRequiredAttributeException. But it also had to be a HTTP exception. That was never the case (also before #313). By removing the first part of the statement, the error message is displayed correctly once again.
MKodde
added a commit
that referenced
this pull request
Apr 4, 2024
When rendering the custom exception page, we test if the MissingRequiredAttributeException. But it also had to be a HTTP exception. That was never the case (also before #313). By removing the first part of the statement, the error message is displayed correctly once again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SF 6, the new exception handler does not show the exception message in the exception handler. Rather, these errors are handled at another point (authn listeners).
Also see: https://stackoverflow.com/questions/40174266/not-all-exceptions-catched-within-the-error-handler