Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep registrants from brute-forcing SMS OTP verification #57

Closed
wants to merge 3 commits into from
Closed

Keep registrants from brute-forcing SMS OTP verification #57

wants to merge 3 commits into from

Conversation

rjkip
Copy link
Contributor

@rjkip rjkip commented Mar 31, 2015

  • Cherry-pick into develop?

@rjkip rjkip force-pushed the feature/prevent-sms-brute-forcing branch 2 times, most recently from e769ab9 to aa4257f Compare April 1, 2015 07:38
@rjkip rjkip force-pushed the feature/prevent-sms-brute-forcing branch from aa4257f to 8f64a3f Compare April 1, 2015 07:42
DRvanR
DRvanR reviewed Apr 2, 2015
View reviewed changes
app/Resources/translations/validators.nl_NL.xliff
<trans-unit id="f355c0b1302e6ed1a9301637306cb312b6feb4eb" resname="ss.prove_phone_possession.too_many_attempts">
<jms:reference-file line="24">Resources/views/translations.twig</jms:reference-file>
<source>ss.prove_phone_possession.too_many_attempts</source>
<target>U heeft de limiet van drie pogingen bereikt; u kunt geen codes meer verifiëren. Neem contact op met uw helpdesk of probeer het later nog eens.</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drie != ten 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:')

Reinier Kip added 2 commits April 2, 2015 10:35
Correct translation: 3 != 10.
32e565e
Prevent verification of a different phone with old OTPs.
56c3aab 
OTPs for other phones are cleared once an OTP is requested for a
specific phone.
@rjkip rjkip closed this Apr 2, 2015
@rjkip rjkip deleted the feature/prevent-sms-brute-forcing branch April 2, 2015 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjkip @DRvanR