After revoking a U2F second factor, revoke U2F device registration from U2F verification server #92
Conversation
| ) | ||
| ); | ||
|
|
||
| return RegistrationRevocationResult::apiError(); |
There was a problem hiding this comment.
This is unrecoverable, the Middleware has already acted: the actual revocation has been executed.
Failure of the GW api is fault-tolerant: it will not cause issues in the future as a new registration will issue a different keyhandle (at least, to my understanding 😉).
Hence I think all GW revoke API errors should be properly logged, but not cause errors to be presented to the user.
There was a problem hiding this comment.
This should not cause any errors to be presented to the user. Actually, I don't even use the revocation result. I still wanted to communicate the result, though.
There was a problem hiding this comment.
uuuuugh, somehow my mind converted all return statements to throw statements :( mi scusi
There was a problem hiding this comment.
Can I freely interpret this as a thumb directed away from the earth's centre?
There was a problem hiding this comment.
why yes, yes you can 👍
ibuildings
WEB & MOBILE APP DEVELOPMENT
Daan van Renterghem
Software Engineer
phone (direct): +31 30 75 51 590
skype: dvrenterghem-ibuildings
e-mail: dvrenterghem@ibuildings.nl
phone: +31 88 00 24 000
www.ibuildings.nl
To all agreements with Ibuildings.nl BV, our general terms and conditions
http://www.ibuildings.nl/algemene_voorwaarden apply.
On Wed, Sep 30, 2015 at 11:36 AM Reinier Kip notifications@github.com
wrote:
In src/Surfnet/StepupSelfService/SelfServiceBundle/Service/U2fService.php
#92 (comment)
:
return RegistrationRevocationResult::apiError();}
$hasErrors = isset($result['errors']) && is_array($result['errors'])&& $result['errors'] === array_filter($result['errors'], 'is_string');
if ($hasErrors && $statusCode >= 400 && $statusCode < 600) {$this->logger->critical(sprintf('U2F registration revocation failed; HTTP %d with errors "%s"',$statusCode,join(', ', $result['errors'])));
return RegistrationRevocationResult::apiError();Can I freely interpret this as a thumb directed away from the earth's
centre?—
Reply to this email directly or view it on GitHub
https://github.com/SURFnet/Stepup-SelfService/pull/92/files#r40775136.
After revoking a U2F second factor, revoke U2F device registration from U2F verification server
No description provided.