Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Feature issue 615 f# nonpublic types #770

Merged

Conversation

SteveGilham
Copy link
Contributor

@SteveGilham SteveGilham commented Oct 15, 2017

The issue or feature being addressed

Addendum for issue #615 -- handle the case of non-public Sum or Record types. This is part of the agreed-to follow-up work in PR #758

Details on the issue fix or feature implementation

Add a parallel set of F# types which are non-public as a sample, and make the same assertions about what is or is not considered for coverage. In the filtering code, mask out the NonPublicRepresentation bit on the F# annotations.

Confirm the following

  • I have ensured that I have merged the latest changes from the main branch (or whichever branch is appropriate) from opencover/opencover
  • I have run build create-release locally and have encountered no issues
  • I agree to follow up on any work required to resolve any issues identified whilst my request is being accepted

This change is Reviewable

@sawilde sawilde merged commit 43b354f into OpenCover:master Dec 2, 2017
@sawilde
Copy link
Member

sawilde commented Dec 2, 2017

thanks

@SteveGilham SteveGilham deleted the feature-issue-615-f#-nonpublic-types branch December 10, 2017 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants