Add vertical view distance

[NotStirred]

No description provided.

[AidanLovelace]

I'm working on this now.

[Barteks2x]

This is not as easy as it may seem. CubeDistanceGraph doesn't really work that way.

[AidanLovelace]

What would be the best way to store a vertical view distance client side? Forge config file? options.txt?

[NotStirred]

1.12.2 had it in config/cubicchunks.cfg as I:verticalCubeLoadDistance

[AidanLovelace]

Ok, I'll do that for now.

[NotStirred]

This is quite a lot of work to do for vertical view to work, good luck...

[AidanLovelace]

Would it be a bad idea to just use the EarlyConfig for now?

[NotStirred]

you can do, I'll be moving that stuff around later anyway

[Barteks2x]

The target is forge config file but there is a problem with that:

in 1.12.2 I could modify forge config from code and store it back. So I could have the vertical view distance slider modify the config value and store it.

Modifying config values from code is no longer possible. So right now just make some dummy setter and getter for it in the config object and leave it to figure out later.

[Barteks2x]

Correction: I read the code now and apparently sometime between last time I looked at it and now an option to set config values programatically has been added.

[AidanLovelace]

Well I suppose I'll create the config.

[Barteks2x]

And no you shouldn't use EarlyConfig for that. EarlyConfig has one purpose: configuring stuff for mixin and stuff that needs to be loaded arbitrarily early. Vertical view distance can be just standard forge client config.

[AidanLovelace]

Okay, I've got vertical view & render distance working. Sort of. This is a hack if you've ever seen one, so be aware, but I've got a prototype.

Commit: AidanLovelace@ed9d112

[NotStirred]

wait im an idiot

[NotStirred]

updated and merged in d41a712