Use ubuntu 22.04, removed support for OCI distribution of ACE/TAO #13
Conversation
jwillemsen
commented
Oct 5, 2023
jwillemsen
commented
* .github/workflows/matrix.yml:
* matrix.py:
* .github/workflows/matrix.yml:
* README.md:
* matrix.py:
* .github/workflows/matrix.yml:
* configure.sh:
* default.settings.sh:
* get_ace_tao.sh:
* setenv.sh:
jwillemsen
changed the title
* .github/workflows/matrix.yml:
* README.md:
* matrix.py:
matrix.py
Outdated
| Ndk('r22b', 19, 30) | ||
| Ndk('r21e', 19, 29) | ||
| Ndk("r20b", 19, 29) | ||
| Ndk("r19c", 19, 28) | ||
| Ndk('r18b', 19, 28) | ||
| Ndk('r12b', 19, 24) |
There was a problem hiding this comment.
You shouldn't have had to do this as these NDKs do support 16. r24 and later are the ones that require at least 19. The reason it was saying that it didn't support 16 is the newer Ubuntu image is including its own Android NDK which is overriding the scripts NDK.
There was a problem hiding this comment.
The underlying issue is still there. It either has to unset ANDROID_NDK before running the scripts or probably easier to rename the ANDROID_NDK variables to something like OPENDDS_ANDROID_NDK.
There was a problem hiding this comment.
Renamed to OPENDDS_ANDROID_NDK
* .github/workflows/matrix.yml:
* README.md:
* matrix.py:
* build_xerces.sh:
* configure.sh:
* get_toolchain.sh:
* setenv.sh:
* .github/workflows/matrix.yml:
* README.md:
* matrix.py:
|
Looks your proposal fixed a lot of the failing checks. Maybe merge this one and when someone has spare time look at the 4 remaining failing checks? |
