XTypes: fixed XCDR2 encoding used for TypeObject #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just making it consistent with the spec - not a breaking change
Generated code that needs these always includes Serializer.h
Requires a phased migration if not all participants change together: - Normal (default) is to be compliant with spec - if some older OpenDDS versions need to interop, set to WriteOldFormat (so they recognize our TypeIdentifiers and we recognize either kind) - once older OpenDDS versions are phased out, set to ReadOldFormat (so correct version is written but incorrect one still understood) - once all participants are on ReadOldFormat, change to Normal (default) Along the way normalized the TypeSupportImpl/TypeLookupService dependency so that the logic of this setting is in one place
mitza-oci
changed the title
possibly fixing safety profile
jrw972
approved these changes
Jun 22, 2021
iguessthislldo
approved these changes
Jun 22, 2021
sonndinh
reviewed
Jun 22, 2021
sonndinh
reviewed
Jun 23, 2021
sonndinh
approved these changes
Jun 23, 2021
mitza-oci
added a commit
that referenced
this pull request
Dec 14, 2021
This reverts commit cf493b4, reversing changes made to 37e64fe. # Conflicts: # dds/DCPS/Serializer.cpp # dds/DCPS/Serializer.h # dds/DCPS/Service_Participant.cpp # dds/DCPS/Service_Participant.h # dds/DCPS/TypeSupportImpl.cpp # dds/DCPS/TypeSupportImpl.h # dds/DCPS/XTypes/TypeLookupService.cpp # dds/DCPS/XTypes/TypeLookupService.h # dds/DCPS/XTypes/TypeObject.h # tests/unit-tests/dds/DCPS/XTypes/TypeObject.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.