RtpsRelay discovery logging and statistics don't handle updates #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- It is expected that RtpsRelay clients will determine and update their server-reflexive address. These updates will appear as new samples in the BITs read by the RtpsRelay. The RtpsRelay will log these updates as new participants, publications, and subscriptions which is misleading. Solution -------- Distinguish between new participants, publications, and subscriptions and updates to existing ones.
mitza-oci
requested changes
Aug 2, 2021
mitza-oci
approved these changes
Aug 2, 2021
jrw972
pushed a commit
that referenced
this pull request
Aug 16, 2021
RtpsRelay discovery logging and statistics don't handle updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is expected that RtpsRelay clients will determine and update their
server-reflexive address. These updates will appear as new samples in
the BITs read by the RtpsRelay. The RtpsRelay will log these updates
as new participants, publications, and subscriptions which is
misleading.
Solution
Distinguish between new participants, publications, and subscriptions
and updates to existing ones.