CMake Asan on GHA and Fixes for CMake on Scoreboard #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use common mechanism to inject compiler and linker arguments that is also used with sanitizers. Also - Default `OPENDDS_DEBUG` and `OPENDDS_INLINE` to true, which are default build features. - Passthrough toolchain file in install test for build on the scoreboard.
mitza-oci
approved these changes
Mar 5, 2022
There was a problem hiding this comment.
Looks like this needs to be resolved before merging:
test_u20_p1_asan_sec
tests/cmake/install/CMakeLists.txt run_test.pl clean-env
/home/runner/work/OpenDDS/OpenDDS/OpenDDS/tests/cmake/build/install/the-install-prefix/bin/opendds_install_test_user: error while loading shared libraries: libTAO_PortableServer.so: cannot open shared object file: No such file or directory
This is DOCGroup/ACE_TAO#1790. |
I thought we had a workaround in place? |
|
We did, but not on the asan build and I didn't think to add it originally. |
mitza-oci
added a commit
that referenced
this pull request
Mar 11, 2022
CMake Asan on GHA and Fixes for CMake on Scoreboard (cherry picked from commit 43c46ed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENDDS_DEBUGandOPENDDS_INLINEto true, which are default build features.