Fixes for shemem and tcp Null Rch #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to OpenDDS#3549 - Fix Coverity CID 1525386 where it noticed the arguments names to GuidPair where flipped from the constructor parameters. This couldn't cause an issue because both insertion and removal where flipped the same way, but this should be fixed anyway. - Commit removal of 2 lines in ShmemDataLink::stop_i that should have gone into the 3549, but I missed when staging the changes chunk by chunk in neovim. - Also fix possible null RcHandle access during shutdown when using tcp that was found when using rr.
mitza-oci
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3549
GuidPairwhere flipped from the constructor parameters. This couldn't cause an issue because both insertion and removal where flipped the same way, but this should be fixed anyway.ShmemDataLink::stop_ithat should have gone into the 3549, but I missed when staging the changes chunk by chunk in neovim.