Fix Configure Submodule Checkout on Windows #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If doing a default build on Windows with `configure` in the Visual Studio Developer Command Prompt and no git installed on the PATH, the configure script's `which` function will erroneously report there is a git command available and try, but fatally fail, to use git to get the commit hash needed for RapidJSON. which is erroneous because it is using `-x`, which seems to return true for directories on Windows. There is a `Git` directory in the PATH that Visual Studio adds that it's picking up. As a side note this actually has a working git command in it, but since it's not on the PATH I'm not sure if we should try to take advantage of it.
mitza-oci
approved these changes
Oct 19, 2022
simpsont-oci
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If doing a normal build on Windows with no git installed on the PATH, the configure script's
whichfunction will erroneously report there is a git command available and try, but fail, to use git to get the commit hash needed for RapidJSON.The which function is erroneous because it is using
-x, which seems to return true for directories on Windows. There is aGitdirectory in the PATH that Visual Studio adds that it's picking up. As a side note this actually has a working git command in it, but since it's not on the PATH I'm not sure if we should try to take advantage of it.Even with these fixes there's still an issue with the 3.22.0 zips because they're missing the
.gitmodulesfile.