DynamicDataReader #3904
Merged
DynamicDataReader #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- DynamicSample is used as type T - not complete, but existing (non-dynamic) use cases should still work
…cific operations The 3 that are "inout" may need to change later if we want the implementation to be able to replace the caller's object
# Conflicts: # dds/DCPS/XTypes/DynamicTypeSupport.cpp # dds/DCPS/XTypes/DynamicTypeSupport.h
This required a way for the empty DynamicSample, before it has data, to know which DynamicType it's used for.
so that it's using the same type parameter on getMetaStruct as is used for content filters, multi-topics,e etc. Cleaned up a few things in RakeResults_T along the way
removed workaround
…omparators" This reverts commit caff427.
Adapted it to allow either reader or writer (eventually both) to be dynamic. Currently the dynamic reader test is commented-out in the test list because it crashes during shutdown.
sonndinh
reviewed
Dec 5, 2022
sonndinh
approved these changes
Dec 5, 2022
iguessthislldo
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicDataReader is an IDL interface defined by the XTypes spec. It is implemented by the class DynamicDataReaderImpl (for now living in DynamicTypeSupport.h), which gets most of its functionality by inheritance from
DataReaderImpl_T<DynamicSample>. This shares the logic of the core DataReader implementation across both static and dynamic language mappings, with small shims in the DynamicTypeSupport.h. These include some template specializations and the DynamicSample type itself, which acts as a wrapper for the DynamicData IDL interface.