Socket handles invalid in RtpsUdpTransport #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- The changes from OpenDDS#3990 created a race where the socket handles are nulled out as part of the transfer to the data link before the `remove_handler` call. Solution -------- Capture the inputs to `register_handler` and `remove_handler` in ReactorInterceptor Commands.
mitza-oci
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The changes from #3990 created a race where the socket handles are nulled out as part of the transfer to the data link before the
remove_handlercall.Solution
Capture the inputs to
register_handlerandremove_handlerin ReactorInterceptor Commands.