Secure writer and reader in same participant do not associate #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
approved these changes
Feb 15, 2023
mitza-oci
reviewed
Feb 15, 2023
Problem ------- A writer and reader in the same participant that uses non-trivial security fail to associate and exchange data. The SingleParticipantWithSecurity tests this scenario but uses an "open" domain so all of the encryption and decryption logic was skipped. Solution -------- * Turn on encryption so that those code paths are exercised in the test. * Fix code paths that cannot handle a remote writer being local.
jrw972
force-pushed
the
same-secure-participant-bug
branch
from
a35d319
to
aa5803d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A writer and reader in the same participant that uses non-trivial security fail to associate and exchange data. The SingleParticipantWithSecurity tests this scenario but uses an "open" domain so all of the encryption and decryption logic was skipped.
Solution