Remove Many Uses of ace/pre.h and ace/post.h
#4123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some headers used `pre.h` without `post.h` which [leaks `pragma pack (push, 8)`]( https://github.com/DOCGroup/ACE_TAO/blob/ab3b192fcda5715a0c92e5627acdeb4e8f71911c/ACE/ace/pre.h#L17) into the code using those headers. Even if this was fixed, it's not clear what is gained by using these headers, except maybe [improved ABI compatibility]( https://github.com/DOCGroup/ACE_TAO/blob/ab3b192fcda5715a0c92e5627acdeb4e8f71911c/ACE/ChangeLogs/ChangeLog-2000a#L9726-L9762), if the alignment changed somehow. OpenDDS doesn't guarantee ABI compatibility at all though, so this seems like this doesn't do anything for us. Instead of using these headers inconsistently, remove them everywhere except for the libraries that consistently use them, the modeling and the QoS XML libraries. Also made some tweaks to the lint script: - Enable the `check_for_pre_and_post` ACE check for the remaining cases of `pre.h` and `post.h`. - Improve logic for finding ACE using `$ACE_ROOT` by treating it as a candidate instead of automatically accepting it. - Fix else brackets.
mitza-oci
approved these changes
Apr 19, 2023
jrw972
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some headers used
pre.hwithoutpost.hwhich leakspragma pack (push, 8)into the code using those headers. Even if this was fixed, it's not clear what is gained by using these headers, except maybe improved ABI compatibility, in case the alignment changed somehow. OpenDDS doesn't guarantee ABI compatibility at all though, so this seems like this doesn't do anything for us. Instead of using these headers inconsistently, remove them everywhere except for the libraries that consistently use them, the modeling and the QoS XML libraries.Also made some tweaks to the lint script:
check_for_pre_and_postACE check for the remaining cases ofpre.handpost.h.$ACE_ROOTby treating it as a candidate instead of automatically accepting it.