Service_Participant does not use ConfigStore
#4138
Merged
+790
−997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
internal-dds-improvements
branch
5 times, most recently
from
4f7226a
to
d114d93
Compare
|
jrw972
force-pushed
the
internal-dds-improvements
branch
3 times, most recently
from
1bc5cf1
to
5f219cf
Compare
sonndinh
reviewed
May 15, 2023
jrw972
force-pushed
the
internal-dds-improvements
branch
2 times, most recently
from
1b2acec
to
10f66c7
Compare
iguessthislldo
requested changes
May 17, 2023
jrw972
force-pushed
the
internal-dds-improvements
branch
3 times, most recently
from
eefe48d
to
8e20e64
Compare
iguessthislldo
requested changes
May 18, 2023
dds/DCPS/Service_Participant.cpp
Outdated
| } | ||
|
|
||
| void | ||
| Service_Participant::n_chunks(size_t chunks) | ||
| { | ||
| n_chunks_ = chunks; | ||
| got_chunks = true; | ||
| config_store_.set_uint32(OPENDDS_COMMON_DCPS_CHUNKS, chunks); |
There was a problem hiding this comment.
Narrowing warnings here and below
Problem ------- The `Service_Participant` does not use the `ConfigStore`. See OpenDDS#4134. Solution -------- Convert the `Service_Participant` to use the `ConfigStore`. * Methods that returned references to configuration values in `Service_Participant` have been removed. * Various strings have changed type. * Each configuration value has a canonical name starting with `OPENDDS`. The rest of the name is taken from its position in the config file by considering the section name. Camelcase is converted into all-caps with underscores. The canonical name resembles an environment variable to enable eventual support for environment variables. See `Service_Participant.h` for the current list of configuration values. * Argument parsing has been consolidated. Arguments starting with `-DCPS`, `-Federation`, or `-OpenDDS` are canonicalized and added to the `ConfigStore`. `-DCPS` and `-Federation` options are prefixed with `OPENDDS_COMMON_`. `-OpenDDS` options are prefixed with "OPENDDS_" after stripping `-OpenDDS`. The ability to pass options via `-OpenDDS` means that any configuration value can be changed via the command line once all modules have adopted the `ConfigStore`. * The configuration file is loaded into the `ConfigStore`. The section name and key are concatenated and canonicalized. * Configuration that involved more than setting a value has been implemented via an Internal DDS Listener. The appropriate values are written into the `ConfigStore` and then the listener is manually invoked for the changes. It is possible to set the listener for the reader if it is necessary to react to changes after the initial configuration.
jrw972
force-pushed
the
internal-dds-improvements
branch
from
8e20e64
to
aa103fb
Compare
iguessthislldo
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Service_Participantdoes not use theConfigStore. See #4134.Solution
Convert the
Service_Participantto use theConfigStore.Methods that returned references to configuration values in
Service_Participanthave been removed.Various strings have changed type.
Each configuration value has a canonical name starting with
OPENDDS. The rest of the name is taken from its position in the config file by considering the section name. Camelcase is converted into all-caps with underscores. The canonical name resembles an environment variable to enable eventual support for environment variables. SeeService_Participant.hfor the current list of configuration values.Argument parsing has been consolidated. Arguments starting with
-DCPS,-Federation, or-OPENDDSare canonicalized and added to theConfigStore.-DCPSand-Federationoptions are prefix withOPENDDS_COMMON_. The ability to passes options via-OPENDDSmeans that any configuration value can be changed via the command line once all modules have adopted theConfigStore.The configuration file is loaded into the
ConfigStore. The section name and key are concatenated and canonicalized.Configuration that involved more than setting a value has been implemented via an Internal DDS Listener. The appropriate values are written into the
ConfigStoreand then the listener is manually invoked for the changes. It is possible to set the listener for the reader if it is necessary to react to changes after the initial configuration.