Some language mappings don't support equality comparison #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
requested changes
May 26, 2023
|
Does this work with valuetypes? The IDL to C++11 language mapping doesn’t define these operators as not all IDL types are comparable, but very likely the subset currently used by OpenDDS does by accident |
No; |
iguessthislldo
requested changes
Jun 6, 2023
iguessthislldo
approved these changes
Jun 7, 2023
iguessthislldo
requested changes
Jun 7, 2023
|
Any documentation extension needed (including warning that the generation of the operator is non-portable and has certain restrictions)? |
jrw972
force-pushed
the
cxx11-equality
branch
2 times, most recently
from
a431549
to
ab721c3
Compare
iguessthislldo
approved these changes
Jun 8, 2023
jrw972
changed the title
Problem ------- The type support for C++11 does not include equality operators (`==` and `!=`). These operators make the IDL defined types easier to use with generic programming techniques. Solution -------- Implement support for `==` and `!=`. Currently, this support is enabled by passed `-Gequality` to `opendds_idl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The type support for C++11 does not include equality operators (
==and!=). The operators make the IDL defined types easier to use with generic programming techniques.Solution
Implement support for
==and!=.