Improve CMake Logging and Library and Program Importing #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
force-pushed
the
igtd/cmake
branch
from
7104896
to
0687aaa
Compare
This simplifies the declaration parts for importing and allows for sharing declaration-related code. Logging from `OPENDDS_CMAKE_VERBOSE` is now expanded and more controllable. Also: - Added executable targets - Added `opendds_export_header` - Corrected `COMPONENTS` documentation - Replaced `NO_*` components with `NO_DEFAULTS` which simplifies things.
Problem ------- The Windows 22 builds using %VCPKG_ROOT% which is defined but incorrect and unquoted. Solution -------- Use the actual location of the installed packages.
iguessthislldo
force-pushed
the
igtd/cmake
branch
from
0687aaa
to
3cf3bd2
Compare
jrw972
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the declaration parts for importing and allows for sharing declaration-related code. Logging from
OPENDDS_CMAKE_VERBOSEis now expanded and more controllable.Also:
opendds_export_headerCOMPONENTSdocumentationNO_*components withNO_DEFAULTSwhich simplifies things.