MulticastInst does not use ConfigStore
#4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
multicast-transport-inst
branch
9 times, most recently
from
db53e19
to
ced1c05
Compare
Problem ------- `MulticastInst` does not use `ConfigStore`. See OpenDDS#4134. Solution -------- Convert `MulticastInst` to use `ConfigStore`. * The following members have been replaced with getters and setters: - default_to_ipv6 - port_offset - group_address - local_address - reliable - syn_backoff - syn_interval - syn_timeout - nak_depth - nak_interval - nak_delay_intervals - nak_max - mak_timeout - ttl - rcv_buffer_size - async_send
jrw972
force-pushed
the
multicast-transport-inst
branch
from
ced1c05
to
71b6811
Compare
iguessthislldo
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MulticastInstdoes not useConfigStore. See #4134.Solution
Convert
MulticastInstto useConfigStore.