ShmemInst does not use ConfigStore
#4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
shmem-transport-inst
branch
2 times, most recently
from
47bbefa
to
75804e2
Compare
Problem ------- `ShmemInst` does not use `ConfigStore`. See OpenDDS#4134. Solution -------- Convert `ShmemInst` to use `ConfigStore`. * The following members have been replaced with getters and setters: - `pool_size_` - `datalink_control_size_`
jrw972
force-pushed
the
shmem-transport-inst
branch
from
75804e2
to
a6cfd3a
Compare
iguessthislldo
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ShmemInstdoes not useConfigStore. See #4134.Solution
Convert
ShmemInstto useConfigStore.pool_size_datalink_control_size_