ConfigStore changes break existing applications #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
config-value
branch
2 times, most recently
from
d1e4504
to
b8e4b20
Compare
iguessthislldo
approved these changes
Sep 6, 2023
Problem ------- Converting TransportInst to ConfigStore is leading to the replacement of raw values with getters and setters. This breaks existing applications. Solution -------- Introduce a value where conversion and assignment dispatch to the corresponding getters and setters.
jrw972
added a commit
to jrw972/OpenDDS
that referenced
this pull request
Sep 13, 2023
Problem ------- Missed the `send_delay_` variable in OpenDDS#4255. Solution -------- Add `send_delay_`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Converting TransportInst to ConfigStore is leading to the replacement of raw values with getters and setters. This breaks existing applications.
Solution
Introduce a value where conversion and assignment dispatch to the corresponding getters and setters.
Closes #4258