DevGuide Cleanup and Improvments #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Security Section - Moved building instructions to building/index. - Restructured to make governance and permissions sections more consistent - Document fnmatch expressions - Simplified anchors at the top of devguide sections. - Formatting in alternate_interfaces_to_data - Fixed minor typos
Also added news and converted opendds_idl options from a table.
So the merge works
jrw972
requested changes
Sep 22, 2023
docs/building/index.rst
Outdated
Comment on lines
117
to
118
| - Xerces-C++ v3.x | ||
| - OpenSSL v1.0.2+, v1.1, or v3.0.1+ |
There was a problem hiding this comment.
Should we consider moving these to some kind of file or is this the only file that contains these versions?
Future work.
There was a problem hiding this comment.
This information is already in the dependencies, so I will just link to Xerces and OpenSSL there. In the future though most of what I added here should probably be generalized and maybe moved to dependencies.
There was a problem hiding this comment.
Yeah, thinking about it more, unless it's trivial like package names or a special case, I don't really want to be in the business of telling people how to build and install FOSS that isn't ours.
Co-authored-by: Justin Wilson <wilsonj@unityfoundation.io>
jrw972
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docconsyntax highlighting tobatch.docconwas the wrong choice because it was for DOS/batch sessions, not actual batch commands.:omgspec:.