MemberDescriptor implementation is incomplete #4339
Merged
+2,118
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
requested changes
Nov 7, 2023
jrw972
force-pushed
the
member-descriptor-impl
branch
from
ba3b7ce
to
11616a2
Compare
sonndinh
reviewed
Nov 9, 2023
sonndinh
reviewed
Nov 13, 2023
jrw972
force-pushed
the
member-descriptor-impl
branch
2 times, most recently
from
6eb50a7
to
27038ee
Compare
iguessthislldo
requested changes
Nov 15, 2023
iguessthislldo
approved these changes
Nov 16, 2023
jrw972
force-pushed
the
member-descriptor-impl
branch
from
d44d5ac
to
bfec7fd
Compare
Problem ------- The MemberDescriptor implementation is incomplete. Completing it is necessary to support user-constructed DynamicTypes. Solution -------- Complete MemberDescriptorImpl. The largest part of the code is devoted to checking that default values are a valid IDL literal for the member type. This prompted the creation of a primitive scanner.
jrw972
force-pushed
the
member-descriptor-impl
branch
from
bfec7fd
to
0844292
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The MemberDescriptor implementation is incomplete. Completing it is necessary to support user-constructed DynamicTypes.
Solution
Complete MemberDescriptorImpl.
The largest part of the code is devoted to checking that default values are a valid IDL literal for the member type. This prompted the creation of a primitive scanner.