Remove disposed instances from DataReader containers #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tances stored in the owner_evaluated_ container. Testing publishing and then unregistering a large number of instances shows that DataReader maps grow in size and never recover.
…andle from the owner_manager, and also remove the entry in the writers_ map. Testing publishing and then unregistering a large number of instances shows that DataReader maps grow in size and never recover.
…ce_i Testing publishing and then unregistering a large number of instances shows that DataReader maps grow in size and never recover.
From review
Fix invalid iterator
jrw972
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing of publishing and then unregistering/disposing a large number of instances shows that DataReader maps grow in size and never recover, taking more and more memory.
We've memory profiled our test apps and then made these modifications to clean up the DataReader containers.
We're not familiar with the inner workings of OpenDDS so it would be good if someone who knows what they're doing could review these changes.
#4334