load_transport_configuration uses ACE_Configuration_Heap
#4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
load-transport-configuration
branch
3 times, most recently
from
5da1db1
to
04867ae
Compare
Problem ------- `load_transport_configuration` uses `ACE_Configuration_Heap` and `ACE_Configuration_Heap` is being removed where possible as part of OpenDDS#4134. Solution -------- Simplify the arguments to only have the file name.
jrw972
force-pushed
the
load-transport-configuration
branch
from
04867ae
to
12938e0
Compare
iguessthislldo
requested changes
Feb 16, 2024
Co-authored-by: Fred Hornsey <fred@hornsey.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
load_transport_configurationusesACE_Configuration_HeapandACE_Configuration_Heapis being removed where possible as part of #4134.Solution
Simplify the arguments to only have the file name.