Set Minimum C++ Standard on CMake Targets #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iguessthislldo
force-pushed
the
igtd/cmake-cxx-std
branch
from
6214e05
to
a1631e4
Compare
jrw972
approved these changes
Feb 21, 2024
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Feb 23, 2024
This continues the work started in OpenDDS#4481 and tries to correctly handle C++ standards in all CMake support. Previously the CMake support was agnostic towards C++ standards, but this meant that building with CMake didn't have a way of differentiating C++ standards. Now we can detect C++ standard support and should be able to build ACE accordingly. Also: - Added `OPENDDS_CXX_STD_YEAR` CMake variable for easy checking of C++ standard support. - In addition to passing `CMAKE_CXX_STANDARD` to the ACE/TAO MPC build, it will also now pass `CMAKE_CXX_COMPILER`. - Removed need for `cmake/detect_ace.pl` - Some of the changes originally in OpenDDS#4374 - MPC location message will now say when it wasn't set. - Split adding of tests between different directories.
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Mar 27, 2024
This continues the work started in OpenDDS#4481 and tries to correctly handle C++ standards in all CMake support. Previously the CMake support was agnostic towards C++ standards, but this meant that building with CMake didn't have a way of differentiating C++ standards. Now we can detect C++ standard support and should be able to build ACE/TAO accordingly. Also: - Added `OPENDDS_CXX_STD_YEAR` CMake variable for easy checking of C++ standard support. - Passing C++ standard to the ACE/TAO MPC builds and `CMAKE_CXX_COMPILER` for gnuace builds. - Removed need for `cmake/detect_ace.pl` - Some of the changes originally in OpenDDS#4374 - MPC location message will now say when it wasn't set. - Split adding of tests between different directories.
iguessthislldo
added a commit
to iguessthislldo/OpenDDS
that referenced
this pull request
Mar 27, 2024
This continues the work started in OpenDDS#4481 and tries to correctly handle C++ standards in all CMake support. Previously the CMake support was agnostic towards C++ standards, but this meant that building with CMake didn't have a way of differentiating C++ standards. Now we can detect C++ standard support and should be able to build ACE/TAO accordingly. Also: - Added `OPENDDS_CXX_STD_YEAR` CMake variable for easy checking of C++ standard support. - Passing C++ standard to the ACE/TAO MPC builds and `CMAKE_CXX_COMPILER` for gnuace builds. - Removed need for `cmake/detect_ace.pl` - Some of the changes originally in OpenDDS#4374 - MPC location message will now say when it wasn't set. - Split adding of tests between different directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #4478